Skip to content

Fix overflow error in ClickHouseLongValue.update method for BigDecimal and BigInteger #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2022
Merged

Fix overflow error in ClickHouseLongValue.update method for BigDecimal and BigInteger #1040

merged 2 commits into from
Aug 13, 2022

Conversation

Blackmorse
Copy link
Contributor

Calling method java.sql.PreparedStatement#setBigDecimal for column with type UInt64 with the value greater than Long.MAX_VALUE results in Overflow error

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link 

Benchmark                                (client)  (connection)  (statement)  (type)   Mode  Cnt     Score     Error  Units
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20   190.367 ±  35.810  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20   191.166 ±  13.939  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20   217.218 ±  33.294  ops/s
Basic.insertOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20   197.298 ±  18.409  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   237.530 ±  32.154  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   201.694 ±  16.676  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20   239.344 ±  33.039  ops/s
Basic.insertOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   190.121 ±  17.064  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse       normal  object  thrpt   20   939.854 ±  91.902  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc         reuse     prepared  object  thrpt   20   998.981 ±  89.705  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new       normal  object  thrpt   20   981.442 ± 113.037  ops/s
Basic.selectOneRandomNumber  clickhouse-http-jdbc           new     prepared  object  thrpt   20  1042.452 ±  84.761  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse       normal  object  thrpt   20   768.042 ±  87.701  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc         reuse     prepared  object  thrpt   20   800.851 ±  57.006  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new       normal  object  thrpt   20   713.100 ±  83.929  ops/s
Basic.selectOneRandomNumber  clickhouse-grpc-jdbc           new     prepared  object  thrpt   20   813.258 ±  44.871  ops/s

@zhicwu zhicwu changed the base branch from master to develop August 13, 2022 21:04
@zhicwu
Copy link
Contributor

zhicwu commented Aug 13, 2022

Thanks for fixing the issue. Actually both signed and unsigned cases should be considered. Will revisit this when introducing byte code engineering. With that, we can add more checks without slowing things down.

@zhicwu zhicwu merged commit 6d79b16 into ClickHouse:develop Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackmorse @CLAassistant @zhicwu